Add context parameter to the callbacks #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d_yarn/typescript-4.1.2 Bump typescript from 4.0.5 to 4.1.2
chore: fix typo
Backquote/backtick symbol (`) is not escaped correctly
Bumps [rollup](https://github.com/rollup/rollup) from 2.33.3 to 2.34.0. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.33.3...v2.34.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.3 to 7.12.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.9/packages/babel-core) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.9 to 14.14.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/rollup-2.34.0
Bumps [prettier](https://github.com/prettier/prettier) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@2.2.0...2.2.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/babel/core-7.12.9
Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.12.7 to 7.12.8. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.8/packages/babel-cli) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/types/node-14.14.10
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.8.1 to 4.8.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.8.2/packages/parser) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/prettier-2.2.1
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 5.4.1 to 5.5.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@v5.4.1...v5.5.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/babel/cli-7.12.8
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.1 to 7.12.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.7/packages/babel-preset-env) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/typescript-eslint/parser-4.8.2
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.8.1 to 4.8.2. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.8.2/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/puppeteer-5.5.0
…d_yarn/babel/preset-env-7.12.7
…d_yarn/typescript-eslint/eslint-plugin-4.8.2
Bumps [rollup](https://github.com/rollup/rollup) from 2.34.0 to 2.34.2. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v2.34.0...v2.34.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.15.0 to 7.0.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v6.15.0...v7.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 10.0.0 to 11.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@node-resolve-v10.0.0...commonjs-v11.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 7.2.0 to 8.0.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v7.2.0...v8.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [rollup-plugin-typescript2](https://github.com/ezolenko/rollup-plugin-typescript2) from 0.29.0 to 0.30.0. - [Release notes](https://github.com/ezolenko/rollup-plugin-typescript2/releases) - [Commits](ezolenko/rollup-plugin-typescript2@0.29.0...0.30.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [form-data](https://github.com/form-data/form-data) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/form-data/form-data/releases) - [Commits](form-data/form-data@v3.0.0...v4.0.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [commander](https://github.com/tj/commander.js) from 7.0.0 to 7.1.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](tj/commander.js@v7.0.0...v7.1.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@rollup/plugin-node-resolve](https://github.com/rollup/plugins) from 11.1.1 to 11.2.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@node-resolve-v11.1.1...node-resolve-v11.2.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/eslint-config-prettier-8.0.0
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.28 to 14.14.31. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.6 to 4.7.7. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.6...v4.7.7) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.14.2 to 4.15.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.15.1/packages/parser) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/rollup-plugin-typescript2-0.30.0
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.12.16 to 7.12.17. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.17/packages/babel-core) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/form-data-4.0.0
…d_yarn/commander-7.1.0
…d_yarn/rollup/plugin-node-resolve-11.2.0
…d_yarn/types/node-14.14.31
…d_yarn/handlebars-4.7.7
…d_yarn/typescript-eslint/parser-4.15.1
…d_yarn/babel/core-7.12.17
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.15.0 to 4.15.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.15.1/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.12.16 to 7.12.17. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.17/packages/babel-preset-env) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/babel/preset-env-7.12.17
…d_yarn/typescript-eslint/eslint-plugin-4.15.1
Bumps [@babel/preset-typescript](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-typescript) from 7.12.16 to 7.12.17. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.17/packages/babel-preset-typescript) Signed-off-by: dependabot-preview[bot] <[email protected]>
…d_yarn/babel/preset-typescript-7.12.17
|
@richgoldmd I merged upstream master, and now generation works. So you can merge this and all should be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found your pull request here: ferdikoomen#434 very useful
However, I feel the missing feature still, is being able to pass some context about the request to the callback. This simple adds this as an optional parameter, so you can pass ie. current user ID down to the callback function to modify headers etc.
I did not manage to get the snapshot generation to work locally unfortunately, could you run it?
Regards,
Hampus Borgos